Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed to mkdocs and use readthedoc theme #167

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

changed to mkdocs and use readthedoc theme #167

wants to merge 12 commits into from

Conversation

QZLin
Copy link

@QZLin QZLin commented Apr 8, 2024

No description provided.

@isaak654
Copy link
Collaborator

isaak654 commented Apr 8, 2024

Unless you click the plus buttons, it is not possible to directly access "Sandboxie Control" and "SBIE Messages" with Firefox 124.0.2 and MS Edge 123.0.2420.81:

firefox_QBR0aQpROL.mp4

@QZLin
Copy link
Author

QZLin commented Apr 8, 2024

That seems the expected behaviour of the mkdocs default readthedoc theme. I will try to change it.

@isaak654
Copy link
Collaborator

isaak654 commented Apr 8, 2024

  1. If you go into the "Usage Tips" page, the minus button is still displayed even when there is nothing below to collapse
  2. The Sandboxie logo feels empty without a sandboxie-docs text next to it
  3. Search highlighting doesn't seem to be supported in the theme, so this can be skipped and postponed later

@isaak654 isaak654 added the High priority To be done as soon as possible label Apr 8, 2024
isaak654
isaak654 requested changes Apr 10, 2024
View reviewed changes
docs/_layouts/default.html Outdated Show resolved Hide resolved
docs/assets/css/style.scss Outdated Show resolved Hide resolved
docs/PlusContent/WFPSupport.md Outdated Show resolved Hide resolved
custom_theme/css/theme_extra.css Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
isaak654
isaak654 reviewed Apr 10, 2024
View reviewed changes
mkdocs.yml Show resolved Hide resolved
@QZLin QZLin requested a review from isaak654 April 12, 2024 04:21
QZLin
QZLin commented May 10, 2024
View reviewed changes
Copy link
Author

@QZLin QZLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the label of logo no longer required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaak654 isaak654 Awaiting requested review from isaak654

Assignees
No one assigned
Labels
High priority To be done as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@QZLin @isaak654 @LepordCat