Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: send to a list of mailboxes #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lzjwlt
Copy link

@lzjwlt lzjwlt commented Nov 12, 2018

Send to a list of mailboxes
config like this:
"notifications":{
"mail":{
"smtpHost":"xxx.com",
"port":25,
"username":"xx@xxx.com",
"password":"xxxxxxxx",
"from":"xx@xx.com",
"to":["a@xx.com", "b@bbb.com", "c@ccc.com"]
}
},

Copy link

@rmorrison61 rmorrison61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, you may want to update the sample_config.json file as well as the README.md and any other documentation related to the configuration. If other users would use that documentation and this PR was merged it wouldn't work for them.

@BobCashStory
Copy link

it woul cause breaking change for all using mail, could you do a support for old and new method ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants