Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requestLimit and targetUrl to request config #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gepo
Copy link

@gepo gepo commented Mar 21, 2017

Related to issue #10, but not solves it completely.

Add 2 options to request config:

  • redirectLimit - Limit for redirects performed while doing HTTP request
  • targetUrl - Expected request url after all redirects has been done

Add 2 options to request config:
 * redirectLimit - Limit for redirects performed while doing HTTP request
 * targetUrl - Expected request url after all redirects has been done
@gepo gepo changed the title Add redirectLimit and targetUrl to request config Add requestLimit and targetUrl to request config Mar 22, 2017
@sanathp
Copy link
Owner

sanathp commented May 14, 2017

Thanks for the pull request @gepo . I feel the name 'redirectLimit' is better than 'requestLimit'.
Whats the reason behind renaming to requestLimit ?

@gepo
Copy link
Author

gepo commented May 22, 2017

I wanted to have the ability both to not limit redirect for request and to forbid any redirects at all, but leave "not limit" logic as default.
If one use a parameter with name redirectLimit then it should be 0 for the case of "forbid any redirects". From another side default value for this parameter if it's not mentioned in json files also 0.
So I just increment value for this paremeter, rename it to requestLimit and use "0" for "not limit", and "1" for "forbid any redicts".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants