Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible poster in Safari #2065

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

oligafner
Copy link

@oligafner oligafner commented Jan 12, 2021

Link to related issue (if applicable)

#2064

Summary of proposed changes

Safari needs to have a set z-index on .plyr__video-wrapper to not hide the poster image, so we inherit z-index from .plyrwith the value of 0.

Checklist

  • Use develop as the base branch
  • Exclude the gulp build (/dist changes) from the PR
  • Test on supported browsers

@sampotts sampotts changed the base branch from develop to master January 29, 2021 12:20
@sampotts sampotts changed the base branch from master to develop January 29, 2021 12:21
@andrxs
Copy link

andrxs commented May 10, 2021

Hi @oligafner:

That solution fixed poster issue, but on full screen captions and video are overlapping.

@regiside
Copy link

regiside commented Aug 5, 2022

Hey guys, seems like setting the z-index to 0 explicitly instead of "inherit" solves the issue for me without any side effects. If that's the case for you guys maybe we can update this pull request and get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants