Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3;added test file #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

robeartoe
Copy link

Made it so it works with Python3. Added test file to test both API and Website. Changed Website portion, to make it easier add webpages and things later on. Changed range_end to always have the correct number without having to manually change everytime.

Copy link
Owner

@sameerkumar18 sameerkumar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has unnecessary dependencies in requirements.txt
See if you can fix those.
Also is flask_restful being used in your code?

@robeartoe
Copy link
Author

robeartoe commented Oct 2, 2017

Oh you're right! It had added more outside of my virtualenv. How odd. Anyways, I fixed that. I only added the requests module and its dependencies.

Yes, flask_restful is still being used, it's being used for the '/api' route. I replaced the '/' route to use Flask instead of flask_restful. Since I noticed you might want to develop a website in the future, setting up the '/' route with Flask is essential, because flask_restful isn't a good tool for delivering webpages and things.

@robeartoe
Copy link
Author

Sorry I'm still kind of new to pull requests and doing all this. So I hope I'm doing this right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants