Use the endpoints.api config value when generating the url on login #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the call to
_getNavigateUrlin theloginmethod is the only case where it is passed without aresource. We found it necessary to addthis.config.endpoints.api.Please note that this change was made by another team member some time ago on 0.4.18. Unfortunately, that team member left no documentation and is no longer working with us, so, quite frankly, we're not sure exactly what problem this solves. But we do know that it was a necessary change.
Does this change conflict with known use cases? Is there a reason no
resourceis passed to_getNavigateUrlonlogin? Finally, if this PR doesn't make sense, is there a better way to achieve the behavior represented by this change?Apologies for being so vague :(