Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Include to the next major release] Remove deprecated functions which are older than 1 year #890

Open
wants to merge 71 commits into
base: development
Choose a base branch
from

Conversation

andrews-moc
Copy link
Contributor

@andrews-moc andrews-moc commented Jan 17, 2024

Developers want to remove deprecated functions which are older than 1 year

Release notes:
Remove deprecated functions which are older than 1 year

Migration guide:

Before After
GliaWidgets.java
GliaWidgets.updateVisitorInfo(VisitorInfoUpdate, Consumer<GliaWidgetException>) GliaWidgets.updateVisitorInfo(VisitorInfoUpdateRequest, Consumer<GliaException>)
GliaWidgets.getVisitorInfo(Consumer<GliaVisitorInfo>, Consumer<GliaWidgetException>) GliaWidgets.getVisitorInfo(RequestCallback<VisitorInfo>)
CallActivity.java
CallActivity.getIntent(Context applicationContext, GliaSdkConfiguration sdkConfiguration, String mediaType) com.glia.widgets.call.Configuration contains MediaType, please use CallActivity.getIntent(Context, Configuration)
CallView.kt
CallView.shouldShowMediaEngagementView() CallView.shouldShowMediaEngagementView(isUpgradeToCall: Boolean)
GliaSdkConfiguration.kt
GliaSdkConfiguration.getContextUrl() Please use Assets and GliaSdkConfiguration.contextAssetId
GliaSdkConfiguration.Builder.contextUrl Please use Assets and GliaSdkConfiguration.Builder.contextAssetId
  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Tests updated? Added? Unit, acceptance, snapshots?
  • Logging for future troubleshooting of client issues added?

BitriseBot and others added 30 commits November 7, 2023 13:06
Made ChatManager able to resend the failed messages.
The ChatAdapter was changed to make the ability to show the failed attachment.
The chat repositories were cleaned up. Now they work only with SendMessagePayload.

MOB-2590
Hide Logger functionality from public usage, add unit tests for Logger class

MOB-2789
Separated audio and video onHold listeners. Now, an audio and a video state are saving separately during onHold.
MOB-2909
- Implement logic to show LO opt-in dialog in chat screen
- Replace ChatManager's action from PublishSubject to BehaviorProcessor
- Remove chat_view.xml unnecessary grouping to prevent a collapsing chain
- Implement logic to show LO opt-in dialog in call screen
- Minor fix in MessagesNotSeenHandler to avoid counting duplicated messages
- Minor fix in AppendNewChatItemUseCase to avoid counting duplicated messages

MOB 2665
gugalo and others added 2 commits January 16, 2024 16:40
Before LO indication pop-up would show even if LO is disabled in site configurations

MOB-2987
@andrews-moc andrews-moc requested review from DavDo, Pelkar, AndriiHorishniiMOC and gugalo and removed request for Pelkar January 17, 2024 09:53
Copy link
Collaborator

@Pelkar Pelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Two notes:

  1. We should create a migration guide for the integrators that can still be using deprecated melthods
  2. Maybe create a new task for next year to clear the deprecated methods again

@andrews-moc
Copy link
Contributor Author

@Pelkar

  1. Maybe create a new task for next year to clear the deprecated methods again

Created MOB-3003 with a due date 01-15-2025

@andrews-moc
Copy link
Contributor Author

andrews-moc commented Jan 23, 2024

@Pelkar

  1. We should create a migration guide for the integrators that can still be using deprecated methods

Added the migration guide to PR description.

@andrews-moc andrews-moc changed the title Remove deprecated functions which are older than 1 year [Include to the next major/minor release] Remove deprecated functions which are older than 1 year Jan 23, 2024
@andrews-moc andrews-moc changed the title [Include to the next major/minor release] Remove deprecated functions which are older than 1 year [Include to the next major release] Remove deprecated functions which are older than 1 year Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants