Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the state on Chat screen if visitor authentication has changed #1034

Conversation

andrews-moc
Copy link
Contributor

Jira issue:
Improve observations for test case #1 from exploratory testing

What was solved?
Since fetch visitor request can receive an error now, Widgets SDK can clear the state on Chat screen if visitor authentication has changed. Otherwise, Chat screen state is invalid.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKsThings to consider for newly added logs in Confluence for more information.

Copy link
Collaborator

@Pelkar Pelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrews-moc andrews-moc merged commit da20aee into feature/MOB-3204_refresh_id_token_interface May 20, 2024
6 of 7 checks passed
@andrews-moc andrews-moc deleted the feature/MOB-3317-do-not-force-stop-requests-on-deauthentication branch May 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants