Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50066 Date Manager export and import csv feature for batch updates #12575

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

JuanDavid102
Copy link
Contributor

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

Copy link
Contributor

@bgarciaentornos bgarciaentornos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, mostly related to spacing

@ern ern changed the title SAK-50066 Date Manager: export / import csv feature for batch updates SAK-50066 Date Manager export and import csv feature for batch updates May 9, 2024
@bgarciaentornos bgarciaentornos requested a review from ern May 24, 2024 06:15
Comment on lines +45 to +50
FilterRegistration requestFilterRegistration = servletContext.addFilter("sakai.request", RequestFilter.class);
requestFilterRegistration.addMappingForUrlPatterns(EnumSet.of(DispatcherType.REQUEST, DispatcherType.FORWARD, DispatcherType.INCLUDE), true, new String[]{"/*"});
requestFilterRegistration.setInitParameter("upload.enabled", "true");

Dynamic servlet = servletContext.addServlet("sakai.datemanager", new DispatcherServlet(rootContext));
servlet.addMapping("/");
servlet.addMapping(new String[]{"/"});
Copy link
Contributor

@ern ern Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of these changes should be needed in this file, just revert them

@ern ern merged commit 821b8d9 into sakaiproject:master Jun 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants