SAK-49285 msgcntr oracle restriction unique violated SYS_C00508178 #11916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ern
reviewed
Sep 20, 2023
| boolean isNew = topic.getId() == null; | ||
|
|
||
| topic.setModified(new Date()); | ||
| if(userId != null){ | ||
| topic.setModifiedBy(userId); | ||
| } | ||
| getHibernateTemplate().saveOrUpdate(topic); | ||
| topic = getHibernateTemplate().merge(topic); |
There was a problem hiding this comment.
I think it is good idea to treat topic as final and simply create a new var called "mergedTopic", it is clearer about what happened.
ern
reviewed
Sep 20, 2023
Comment on lines
+1178
to
1180
| forum = getHibernateTemplate().merge(forum); | ||
| area = getHibernateTemplate().merge(area); | ||
|
|
There was a problem hiding this comment.
Same here use mergedForum and mergedArea
ern
reviewed
Sep 20, 2023
Comment on lines
+308
to
+309
| newItems.add(item); | ||
| newItems = saveSynopticMsgcntrItems(newItems); |
There was a problem hiding this comment.
this code could be less confusing newItems is never used in the way that it is declared at the top of the method.
ern
reviewed
Sep 20, 2023
Comment on lines
-348
to
+353
| saveSynopticMsgcntrItems(Arrays.asList(item)); | ||
| newItems.add(item); | ||
| newItems = saveSynopticMsgcntrItems(newItems); |
|
@jesusmmp are you interested in getting this merged? |
|
I'll fix this PR in the summer |
ern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-49285