Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-48874 Assignments implementation of Interface HardDeleteAware #11569

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

jkjanetschek
Copy link
Contributor

This implementation is using the Interface HardDeleteAware. Only data which concerns the tool is considered.

@jkjanetschek jkjanetschek marked this pull request as draft May 17, 2023 11:57
@jkjanetschek
Copy link
Contributor Author

This PR is related to PR SAK-48874 Assignments support removal of data when site is hard deleted #11547
https://github.com/sakaiproject/sakai/pull/11547

@ern
Copy link
Contributor

ern commented May 19, 2023

Hi @jkjanetschek, I looked this over and will add the missing bits to the other PR.

One thing I noticed while looking at this, is interfaces like HardDeleteAware are not designed and implemented properly.
The design is that the entity (object) broker system should be responsible for calling notifying it's entities that something is occurring and action should be taken by the affected entities, in this case a site is being removed so the related entities should be removed. However It should be the responsibility of the EntityManager to initiate the appropriate action (EntityManager would need to be informed that such an action is happening likely by the SiteRemovalAdvisor).

So in the end a few adjustments will be needed to properly reflect this chain of command.

Thank you for pointing this out!

@ern ern self-assigned this Jun 5, 2023
@ern ern changed the title SAK-48874: tool Assignments implementation of Interface HardDeleteAware SAK-48874 Assignments implementation of Interface HardDeleteAware Dec 12, 2023
@ern ern marked this pull request as ready for review June 3, 2024 18:45
@ern ern merged commit 7ca0102 into sakaiproject:master Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants