some polishing for pbori (ruff and pep8 mostly) #37965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 22ed71b; changes) is ready! 🎉 |
mkoeppe
reviewed
May 9, 2024
Comment on lines
637
to
639
| def _test(): | ||
| import doctest | ||
| doctest.testmod() |
|
The failure in test-long is "Random testing has revealed a problem in test_karatsuba_multiplication", unrelated. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
just a basic polish of the ` pbori` folder, fixing pep8 warnings and
some ` ruff` suggestions
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37965
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
just a basic polish of the ` pbori` folder, fixing pep8 warnings and
some ` ruff` suggestions
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37965
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a basic polish of the
pborifolder, fixing pep8 warnings and someruffsuggestions📝 Checklist