Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various ruff fixes in combinat #37958

Merged
merged 4 commits into from May 12, 2024
Merged

various ruff fixes in combinat #37958

merged 4 commits into from May 12, 2024

Conversation

fchapoton
Copy link
Contributor

just fixing some ruff suggestions in combinat

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

Documentation preview for this PR (built with commit 300fa32; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton @mkoeppe
Apply suggestions from code review
0a1292a 
details in formatted strings

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@fchapoton @mkoeppe
Apply suggestions from code review
300fa32 
about code formatting

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
mkoeppe
mkoeppe approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
sagemathgh-37958: various ruff fixes in combinat
67f1638 
    
just fixing some `ruff` suggestions in `combinat`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37958
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
sagemathgh-37958: various ruff fixes in combinat
f3ae9ab 
    
just fixing some `ruff` suggestions in `combinat`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37958
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Matthias Köppe
@vbraun vbraun merged commit 175d57b into sagemath:develop May 12, 2024
17 checks passed
@fchapoton fchapoton deleted the various_ruff_in_combinat branch May 12, 2024 19:57
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: combinatorics t: refactoring v: large
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fchapoton @mkoeppe @vbraun