Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various ruff suggestions fixed in schemes #37947

Merged
merged 1 commit into from May 12, 2024
Merged

various ruff suggestions fixed in schemes #37947

merged 1 commit into from May 12, 2024

Conversation

fchapoton
Copy link
Contributor

This is fixing some details, as suggested by ruff in the schemes folder.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton changed the title various ruff sugeestions fixed in schemes various ruff suggestions fixed in schemes May 6, 2024
tscrim
tscrim approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although the changes in `plane_curve_arrangement.py now break the PEP8 alignment, but PEP8 stuff can be done seprately).

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Documentation preview for this PR (built with commit 604d6a4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
sagemathgh-37947: various ruff suggestions fixed in schemes
c7498a6 
    
This is fixing some details, as suggested by `ruff` in the `schemes`
folder.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37947
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
sagemathgh-37947: various ruff suggestions fixed in schemes
5906b63 
    
This is fixing some details, as suggested by `ruff` in the `schemes`
folder.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37947
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
sagemathgh-37947: various ruff suggestions fixed in schemes
85195af 
    
This is fixing some details, as suggested by `ruff` in the `schemes`
folder.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37947
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 7f5ae5c into sagemath:develop May 12, 2024
19 checks passed
@fchapoton fchapoton deleted the ruff_in_schemes branch May 12, 2024 19:58
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fchapoton @tscrim @vbraun @mkoeppe