feat(api-kit): add ZkSync and ZkEvm service links #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagopv
approved these changes
Mar 11, 2024
Pull Request Test Coverage Report for Build 8236751147Details
💛 - Coveralls |
dasanra
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #729
How this PR fixes it
Add ZkSync and ZkEvm to the default
api-kitconfiguration.Also removed goerli from the default configuration, as is not supported anymore. Added few changes in the tests to avoid complaining because Goerli service is not available.
Tests are pending to be fully migrated to Sepolia yet.