Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify LIANA + MOFA vignette #102

Open
dbdimitrov opened this issue Apr 17, 2024 · 2 comments
Open

Clarify LIANA + MOFA vignette #102

dbdimitrov opened this issue Apr 17, 2024 · 2 comments
Assignees
@dbdimitrov
Labels
enhancement New feature or request

Comments

@dbdimitrov
Copy link
Collaborator

dbdimitrov commented Apr 17, 2024 •
edited

  • pass sample_key explicitly
  • Make sure e.g. samples_per_view is a visible as a QC metric, and reduce it?
  • mention th keep_stats parameter
  • be explicit about resource_name
@dbdimitrov dbdimitrov added the enhancement New feature or request label Apr 17, 2024
@dbdimitrov dbdimitrov self-assigned this Apr 17, 2024
@decusInLabore
Copy link

Perhaps automatically reduce the 'samples_per_view' default parameter if mandated by the dataset structure. Alternatively, add a comment in the vignette.

@decusInLabore
Copy link

decusInLabore commented Apr 17, 2024 •
edited

In the vignette, review the mentions fo the li.mt.rank_aggregate.by_sample function add/mention the resource_name = "mouseconsensus" parameter explicitly to cater for mouse studies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbdimitrov dbdimitrov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@decusInLabore @dbdimitrov