New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expense module remaining work #1706
base: develop
Are you sure you want to change the base?
Conversation
handleEdit={handleEdit} | ||
/> | ||
<Expense currency={company.base_currency} expense={expense} /> | ||
{!isDesktop && showEditExpenseModal ? null : ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use && and remove null by altering condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this can not be refactored, If we use the altering condition, it breaks on mobile view.
Returning null is necessary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the failing spec
Notion:
What: