Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: add gstreamer libraries #1263

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

soumyaDghosh
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.05%. Comparing base (3cbffdd) to head (da97bb3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1263   +/-   ##
=======================================
  Coverage   36.05%   36.05%           
=======================================
  Files         115      115           
  Lines        9070     9070           
=======================================
  Hits         3270     3270           
  Misses       5800     5800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adil192
Copy link
Member

adil192 commented May 15, 2024

We may also need libgstreamer-plugins-base1.0-dev for ogg support, but I'm not sure if that's necessary here?

@adil192 adil192 changed the title add gstreamer devel libraries snap: add gstreamer libraries May 15, 2024
@soumyaDghosh
Copy link
Collaborator Author

We may also need libgstreamer-plugins-base1.0-dev for ogg support, but I'm not sure if that's necessary here?

The libraries are in the runtime sdk, but the pkgconfig and development files got removed in the sdk, thus the need of these files. So, we need files mostly to satisfy the build. I'll try to look into it once again.

@adil192 adil192 marked this pull request as draft May 18, 2024 17:35
@adil192
Copy link
Member

adil192 commented May 18, 2024

Please mark this as "ready for review" when you're ready

@adil192
Copy link
Member

adil192 commented May 29, 2024

I'll just merge this for now to try and get builds working

@adil192 adil192 marked this pull request as ready for review May 29, 2024 06:09
@adil192 adil192 merged commit 67ac53e into saber-notes:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants