Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Customizable toolbar button size #1182

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

QubaB
Copy link
Contributor

@QubaB QubaB commented Mar 18, 2024

Implemented 3 different sizes of toolbar buttons to allow user to choose smaller buttons if toolbar takes too big area of screen.

Closes #1146
also partialy closes #1177 (here probably the possibility to hide toolbar when typing text will be better solution - for example long press on text toolbar button)

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 37.61468% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 37.56%. Comparing base (5b64bd8) to head (a6b285d).
Report is 86 commits behind head on main.

❗ Current head a6b285d differs from pull request most recent head a58825e. Consider uploading reports for the commit a58825e to get more accurate results

Files Patch % Lines
lib/pages/home/settings.dart 0.00% 29 Missing ⚠️
lib/components/toolbar/toolbar_button.dart 50.00% 15 Missing ⚠️
lib/components/toolbar/pen_modal.dart 0.00% 6 Missing ⚠️
lib/components/toolbar/size_picker.dart 0.00% 6 Missing ⚠️
lib/components/toolbar/toolbar.dart 58.33% 5 Missing ⚠️
lib/components/toolbar/color_bar.dart 73.33% 4 Missing ⚠️
lib/data/prefs.dart 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
+ Coverage   37.49%   37.56%   +0.06%     
==========================================
  Files         108      108              
  Lines        8564     8668     +104     
==========================================
+ Hits         3211     3256      +45     
- Misses       5353     5412      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QubaB
Copy link
Contributor Author

QubaB commented Mar 19, 2024

I probably did not choosed the best way. If you @adil192 tell me how to do it better, I rewrite code.

I would like to have this option. Now my toolbar takes up two lines.

lib/components/toolbar/toolbar_button.dart Outdated Show resolved Hide resolved
lib/i18n/strings.g.dart Show resolved Hide resolved
@QubaB QubaB requested a review from adil192 May 11, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar in two rows after pencil button was added Text Feature ist unusable
2 participants