Move selection to another page #1085
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
- Coverage 37.42% 37.07% -0.36%
==========================================
Files 110 110
Lines 8599 8675 +76
==========================================
- Hits 3218 3216 -2
- Misses 5381 5459 +78 ☔ View full report in Codecov by Sentry. |
added 3 commits
February 27, 2024 11:03
Undo/redo is not handled correctly because old items are deleted and new created.
In Select added pageIndexStart holding original page of selection. In EditorHistory added pageIndexStart - important only for move Solving issue saber-notes#932
adil192
force-pushed
the
MoveSelectionToAnotherPage
branch
from
b5c1609
to
d5b7142
Compare
added 3 commits
April 1, 2024 07:17
…selection movement is stored to history. This fixes problem when selection is moved across pages, and then moved on page (in this case pageIndexStart was set according to the first movement of selection)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented moving selection across pages. Undo/redo works.
In Select added pageIndexStart holding original page of selection.
In EditorHistory added pageIndexStart - important only for move
In Editor is mainly change onDrawUpdate which should handle moving items to another page.
Closes #932