This repository has been archived by the owner on Aug 19, 2023. It is now read-only.
Add check that literal values are valid to decode_field #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an explicit check that a literal field has a valid value when decoding. This will improve decoding when types in a Union have overlapping fields but may be discriminated by a literal.
|
Fix for #163 |
|
@s-knibbs Looks like I can't add you as an assignee, but hope this looks good! |
s-knibbs
reviewed
Sep 30, 2021
s-knibbs
reviewed
Sep 30, 2021
|
Fixes #163 |
|
@s-knibbs updated re: your feedback |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an explicit check that a literal field has a valid value when decoding. This will improve decoding when types in a Union have overlapping fields but may be discriminated by a literal.