Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PWA manifest and icons, template updates. #475

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noahlange
Copy link
Contributor

What does this do?

Adds a PWA manifest and icons. I made additional changes to the header template and .gitignore file to add the appropriate <link /> tag and un-ignore the manifest.

I generated crop dimensions for the icons using smartcrop.js and compressed with pngquant.

Is there a GitHub Issue that this is resolving?

Yes, it's a start on #454. We'll need to create a service worker before it can be closed, however.

@Glinkis
Copy link
Collaborator

Glinkis commented Dec 29, 2020

I'm not entirely familiar with how PWAs work but don't we need to genenerate a list of all the app files?

@noahlange
Copy link
Contributor Author

I'm not entirely familiar with how PWAs work but don't we need to generate a list of all the app files?

According to Google, the only other thing that's mandatory is a service worker—Chrome didn't indicate there were any other issues when I opened the application panel in the dev tools.

@ryceg
Copy link
Owner

ryceg commented Jan 21, 2021

What's the state of this? Are we shelving the PWA for the moment?

@noahlange
Copy link
Contributor Author

I dunno, and I'm not entirely sure what a proper service worker entails.

@ryceg
Copy link
Owner

ryceg commented Jan 21, 2021

Haha! Righto, guess this one will just sit on the backburner while we wait for somebody with a bit more know-how to show us how it's done :)

@ryceg ryceg marked this pull request as draft January 22, 2021 04:55
@ryceg ryceg added feature request This would add new functionality good first issue Good for newcomers help wanted Extra attention is needed labels Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This would add new functionality good first issue Good for newcomers help wanted Extra attention is needed
Projects
Engine
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants