Create-library #437
Draft
Create-library #437
+843
−473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glinkis
reviewed
Dec 22, 2020
| author?: Namesake | ||
| } | ||
|
|
||
| type BookCategories = |
There was a problem hiding this comment.
If you select this chunk of code and run format selection, it will standardize the typescript formatting.
Glinkis
reviewed
Dec 22, 2020
| interface BookData { | ||
| title: string | ||
| /** The Dewey system hasn't been invented yet, but... */ | ||
| category: BookCategories[] |
There was a problem hiding this comment.
I'd rename this to categories, to indicate its plurality.
Glinkis
reviewed
Dec 22, 2020
| ] | ||
| } | ||
|
|
||
| export const library = { |
There was a problem hiding this comment.
Empty object can be removed?
There was a problem hiding this comment.
Not yet- the PR isn't even close to being complete, it's just so people can see what's being worked on so we don't get duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds a library.
How was this tested? Did you test the changes in the compiled
.htmlfile?Is there a GitHub Issue that this is resolving?
Closes #265.