Skip to content

Commit

Permalink
More tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanrolds committed Jan 29, 2023
1 parent 702b704 commit cb6db59
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 2 deletions.
31 changes: 31 additions & 0 deletions testdata/sqlx_examples/correct_generics.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package sqlx_examples

import (
"log"
"strings"
)

func correctSqlCloseCheckG[T ~int64]() {
age := 27
rows, err := db.Queryx("SELECT name FROM users WHERE age=?", age)
if err != nil {
log.Fatal(err)
}

defer rows.Close()

names := make([]string, 0)
for rows.Next() {
var name string
if err := rows.Scan(&name); err != nil {
log.Fatal(err)
}
names = append(names, name)
}

// Check for errors from iterating over rows.
if err := rows.Err(); err != nil {
log.Fatal(err)
}
log.Printf("%s are %d years old", strings.Join(names, ", "), age)
}
4 changes: 2 additions & 2 deletions testdata/sqlx_examples/failure_generics.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ package sqlx_examples
import "database/sql"

func SqlCloseCheck(db *sql.DB, a int) {
rows, _ := db.Query("select id from tb") // <- detected OK
rows, _ := db.Query("select id from tb")
for rows.Next() {

}
}

func SqlCloseCheckG[T ~int64](db *sql.DB, a T) {
rows, _ := db.Query("select id from tb") // <- not detected KO
rows, _ := db.Query("select id from tb")
for rows.Next() {

}
Expand Down

0 comments on commit cb6db59

Please sign in to comment.