Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #161 gates do not open #727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lihis
Copy link
Contributor

@Lihis Lihis commented Oct 26, 2019

Fixes the gates opening/closing.

Distance to stop the gate when it's closing and would collide with a ped or a car has been tuned with eye precision so not 1:1 with original game.

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #727 into master will decrease coverage by 6.99%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #727     +/-   ##
=========================================
- Coverage   18.12%   11.12%     -7%     
=========================================
  Files         252      252             
  Lines       22938    22976     +38     
  Branches     5769     5794     +25     
=========================================
- Hits         4158     2557   -1601     
- Misses      17659    18890   +1231     
- Partials     1121     1529    +408
Impacted Files Coverage Δ
rwengine/src/script/modules/GTA3ModuleImpl.inl 0% <0%> (ø) ⬆️
rwengine/src/loaders/LoaderCutsceneDAT.cpp 6.55% <0%> (-40.99%) ⬇️
tests/test_FileIndex.cpp 40.81% <0%> (-38.78%) ⬇️
rwcore/platform/FileIndex.cpp 12.04% <0%> (-38.56%) ⬇️
rwengine/src/loaders/LoaderIPL.cpp 53.68% <0%> (-32.64%) ⬇️
rwengine/src/loaders/LoaderIDE.cpp 35.75% <0%> (-30.06%) ⬇️
tests/test_Text.cpp 65.55% <0%> (-30%) ⬇️
tests/test_LoaderDFF.cpp 59.45% <0%> (-29.73%) ⬇️
tests/test_Menu.cpp 70.58% <0%> (-29.42%) ⬇️
rwengine/src/engine/GameData.cpp 4.21% <0%> (-29.31%) ⬇️
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b7264...b409a8c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant