Improve player vehicle enter behaviour #725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the vehicle enter behaviour was extremely buggy and would sometimes cause the player to get stuck in an animation. This patch brings the behaviour more inline with the actual game behaviour, although it is still not completely correct.
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
==========================================
- Coverage 18.12% 18.11% -0.02%
==========================================
Files 252 252
Lines 22938 22958 +20
Branches 5769 5776 +7
==========================================
Hits 4158 4158
- Misses 17659 17677 +18
- Partials 1121 1123 +2
Continue to review full report at Codecov.
|
Lihis
approved these changes
Oct 26, 2019
EduardoZFerreira
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the exit vehicle pull request, this one improves entering a vehicle