Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for conversions of paths #608

Merged
merged 1 commit into from
May 28, 2024
Merged

Implement support for conversions of paths #608

merged 1 commit into from
May 28, 2024

Conversation

filmor
Copy link
Member

@filmor filmor commented May 2, 2024 •
edited

@filmor filmor marked this pull request as ready for review May 16, 2024 08:13
@filmor filmor requested a review from evnu May 27, 2024 20:13
evnu
evnu approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@evnu evnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wondered if a path could legally be non-utf8 and thus fail on decode, wdyt?

@filmor
Copy link
Member Author

filmor commented May 28, 2024

It could be, but I think it's a valid assumption that binaries from the BEAM that are supposed to represent strings are encoded UTF-8. If we ever get a request from someone who wants this to work with different encodings, we can act at that time :)

@filmor filmor merged commit b882d51 into master May 28, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evnu evnu evnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filmor @evnu