Generate less bloaty code for errors::windows
enums
#861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really intended to be merged, feel free to ignore. This solves #847, but at the cost of tons of generated code.
This is just an experiment to see if custom
Debug
andfrom_u64/u32
code based on PHF leads to better codegen.On my windows system, a full lto compile using
cargo bloat
shrinks the resulting binary ofminidump-stackwalk
by 100k, (from 10M to 9.9M), with a tiny regression to the debug data size.The full story of what I did is documented here: https://swatinem.de/blog/optimizing-enums/
Ideally the Rust compiler would do this optimization internally and not generate such code in the first place.