-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: http-symbol-supplier configurability #647
base: main
Are you sure you want to change the base?
Conversation
Gankra
commented
Aug 2, 2022
- Add a bunch of options to http symbol supplier so it's easier to turn on/off the various symbol lookup modes / features.
- Add an expandable options struct and a new constructor function for using the options struct
- Add a new use_minidump_paths mode to run dump_syms on the codefile and debugfile paths in the minidump, enabling local symbolication on the same machine that crashed/built
- Expose some of those options as minidump-stackwalk flags
Some experimental notes on --use-minidump-paths=true:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me.
The only thing that jumped out to me was the invocation of dump_syms, which, on Windows, might be called with both the code file and the debug file. I'm not exactly sure how dump_syms deals with having both because it also has some autodetection to find the pdb for an exe and the exe for a pdb. It might dump both files twice and then merge the result. In any case, if this doesn't work the way we want it to, it should be fixed in dump_syms and not here - passing both seems like a fine API.
In the current impl if we get two files we only use the "better" one (determined by the caller's ordering of the inputs). In this impl we pass the debugfile second, meaning it's preferred. In the event that the codefile and debugfile are in separate directories ( |
TODO:
|