Don't ICE when we have leftover child captures due to ambiguous closure params #124525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
leftover-captures
branch
from
92cdff1
to
9d50d34
Compare
oli-obk
reviewed
Apr 30, 2024
Comment on lines
+6
to
+9
| async |unconstrained| { | ||
| //~^ ERROR type annotations needed | ||
| (test,) | ||
| }; |
There was a problem hiding this comment.
This error is not very helpful to users. Can we link the inference variable of the coroutine with the one of the unconstrained argument?
|
r=me with some improvement to the diagnostic or at least an issue open and linked from the tracking issue |
oli-obk
added
S-waiting-on-author
|
No longer necessary since #124902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ExprUseVisitor, we bail out when we encounter infer types. That means that the captures that we pass intoanalyze_coroutine_closure_capturesaren't actually lined up correctly, and we ICE. Turn this into a delayed bug.Fixes #123901
r? oli-obk