Recommend to never display zero disambiguators when demangling v0 symbols #124514
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the v0 symbol mangling documentation with the strong recommendation that demanglers should never display zero-disambiguators, especially when dealing with
crate-root
.Being able to rely on
C3foo
to be rendered asfoo
(i.e. without explicit disambiguator value) rather than asfoo[0]
allows the compiler to encode things like new basic types in a backward compatible way. This idea has been originally proposed by @eddyb in the discussion around supportingf16
andf128
in the v0 mangling scheme. It is a generally useful mechanism for supporting a certain class of new elements in the v0 mangling scheme in a backward compatible way (whether as a temporary workaround until downstream tooling has picked up grammar changes or as a permanent encoding).cc @tgross35