Add nix to default languages #2262
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehuss, @Dylan-DPC , please, review. I'd like to use Nix highlighting in numtide/devshell docs. |
|
You can relatively easily use it already, but native support would be nicer. |
|
@ehuss, @jalil-salame, can you please merge? |
|
@deemp I just reviewed it, I don't have merge rights c: |
|
Thanks for the PR! Unfortunately we are not able to update highlight.js. Can you make sure this is built with 10.1.1? |
ehuss
added
S-waiting-on-author
|
Hey @ehuss I updated highlight js with the exact 10.1.1 version. Is there anything else I should do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2261
While I could maintain my own highlight.js for my Project, this would probably benefit a few users. Esp. since mdBook is already quite common in the nix-community, for example the Nix Reference Manual uses it.