Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update google-analytics and add ipv6 localhost address #2216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ettoreleandrotognoli
Copy link

resolves #2215

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Oct 9, 2023
Copy link

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable based on the installation instructions at https://developers.google.com/tag-platform/tag-manager/datalayer#installation

It would be worth showing you've tested this with a couple of screenshots.

@ettoreleandrotognoli
Copy link
Author

ettoreleandrotognoli commented Oct 18, 2023

The site that I'm using it is this one:
https://ettoreleandrotognoli.gitlab.io/unimar-object-oriented-programming-i/

This print any one can reproduce inspecting the site:
Screenshot from 2023-10-18 18-19-46

This one is from the google analytics site, it needs authentication
Screenshot from 2023-10-18 18-21-50

I'm using the mdBook version from my personal repo to build it
https://gitlab.com/ettoreleandrotognoli/unimar-object-oriented-programming-i/-/blob/main/Dockerfile?ref_type=heads#L9

Copy link

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehuss
Copy link
Contributor

ehuss commented Nov 24, 2023

I'm reluctant to merge this since the google analytics option is deprecated and is intended to be removed (there is also a large warning telling you not to use it). I also don't particularly want to research to see what the possible consequences of changing this are. I have a vague understanding that Google has changed from one system to another, but I don't know if that migration would break existing configurations, or what the status is of that migration.

I'm going to suggest that instead of fixing the code here that you use a custom theme/head.hbs file instead.

@KFearsoff
Copy link
Contributor

I'm going to suggest that instead of fixing the code here that you use a custom theme/head.hbs file instead.

I think it's a good idea, but it would be nice to include the code snippet into documentation (into the separate "user-contributed" section in mdbook's book, perhaps?). This is a good contribution and I think it shouldn't go to waste even if we pull the plug on supporting Google Analytics. After that we can consider closing the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-analytics is not working
5 participants