New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update google-analytics and add ipv6 localhost address #2216
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable based on the installation instructions at https://developers.google.com/tag-platform/tag-manager/datalayer#installation
It would be worth showing you've tested this with a couple of screenshots.
The site that I'm using it is this one: This print any one can reproduce inspecting the site: This one is from the google analytics site, it needs authentication I'm using the mdBook version from my personal repo to build it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm reluctant to merge this since the google analytics option is deprecated and is intended to be removed (there is also a large warning telling you not to use it). I also don't particularly want to research to see what the possible consequences of changing this are. I have a vague understanding that Google has changed from one system to another, but I don't know if that migration would break existing configurations, or what the status is of that migration. I'm going to suggest that instead of fixing the code here that you use a custom |
I think it's a good idea, but it would be nice to include the code snippet into documentation (into the separate "user-contributed" section in mdbook's book, perhaps?). This is a good contribution and I think it shouldn't go to waste even if we pull the plug on supporting Google Analytics. After that we can consider closing the PR? |
resolves #2215