fix Menu bar shakes when swiping pages in Safari #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rustbot label +A-style |
ehuss
reviewed
Aug 5, 2023
There was a problem hiding this comment.
I'm not able to reproduce the issue mentioned in #2119. Can you say what kind of hardware you have? I tried on a 10-year old macbook, and didn't see any shaking or rendering issues. If you update to the latest safari (I have 16.6), does that help?
| will want to reposition the viewport in a weird way. | ||
| */ | ||
| overflow-x: clip; | ||
| @media only screen and (max-width: 420px) { |
There was a problem hiding this comment.
Can you say where you got this 420 value? It seems like this wouldn't work with larger iPhones, like the Pro Max versions which have a greater than 420 size. Is there some other criteria that can be used to detect the scenarios where it is needed?
|
@rustbot author |
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2119
The style
should only make effect in mobile Safari.