Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blockquote styles for collapsible-blockquote #2058

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

expikr
Copy link
Contributor

@expikr expikr commented Apr 9, 2023

image

image

image

image

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Apr 9, 2023
@expikr expikr changed the title use blockquote theme for collapsible details use blockquote style for collapsible details Apr 9, 2023
@expikr expikr changed the title use blockquote style for collapsible details Use blockquote styles for collapsible-blockquote Apr 9, 2023
@ehuss
Copy link
Contributor

ehuss commented May 13, 2023

Can you say why this would be added instead of putting the <details> block inside a blockquote? For example:

CLICK ME

Content goes here.

In general, when opening a pull request, it would be helpful to include some text explaining what a PR does and what the motivation is behind it.

@ehuss
Copy link
Contributor

ehuss commented May 28, 2023

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: waiting on a review labels May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants