Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ch19-01-unsafe-rust.md #3739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mirthfulLee
Copy link

Original expression Any code that reads or writes from ... should be Any code that reads from or writes to ....
However, compared with access or modify, read from or write to is more tedious but less accurate.
Besides, access or modify also has greater consistency with context : )

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I understand what you're going for here. However, I think the original is perfectly comprehensible here, and given the overhead of updates to the print book, we are only making changes like this where they are fixing actual bugs or meaningful grammatical mistakes. I think reads or writes from is such a mistake, but let's go with making it just reads from or writes to, rather than making a more general wording change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants