Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ch10-03 #3539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in ch10-03 #3539

wants to merge 1 commit into from

Conversation

paldepind
Copy link

The "if" seems misplaced. When reading it feels like "if" refers to "deterministically" as if the compiler might sometimes apply the rules nondeterministically 馃槄

The "if" is misplaced. Rust definitely deterministically applies the rules 馃槂
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one definitely keeps tripping people up, so I agree it needs a fix! 馃 I think the phrasing we actually need is probably something like:

The elision rules don鈥檛 provide full inference. If there is still ambiguity as to what lifetimes the references have after Rust applies the rules, the compiler won鈥檛 guess what the lifetime of the remaining references should be.

If you鈥檇 like to update the PR with that, please do; if you鈥檙e busy with other things, just let me know and I will push to the PR with that instead.

@paldepind
Copy link
Author

Thanks for the comment. Agree that it would be great to get this fixed.

What about this (my change in italics):

The elision rules don鈥檛 provide full inference. If there is still ambiguity as to what lifetimes the references have after Rust have applied the rules, the compiler won鈥檛 guess what the lifetime of the remaining references should be.

I'm not a native speaker but to me it feels like "apply" needs to be in past time (i.e. "applied" instead of "applies") due to the use of "after".

Could also be:

The elision rules don鈥檛 provide full inference. If there is still ambiguity as to what lifetimes the references have after the rules have been applied, the compiler won鈥檛 guess what the lifetime of the remaining references should be.

This removes "Rust" which I think simplifies the sentence a bit because the compiler is the only acting part instead of both having "Rust" and "the compiler" as something that does something in the same sentence.

In any case I'll be happy to update the PR.

@chriskrycho
Copy link
Contributor

Thanks for the response! For what it鈥檚 worth, the way I phrased it is actually very idiomatic English!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants