Basic Fuzzing Support and a Fix for a uncovered Bug during decoding of dynamic arrays #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a basic fuzzing harness to support fuzzing the decoder with
cargo fuzz. After a small fuzzing run this uncovered another issue in the new decoder of v14. Similar to the issue with the dynamic tuples (see #203), there is an issue with dynamic arrays size leading to an out-of-bounds access, which causes rust to panic. The fix is quite the same as for the tuple issue.Currently the current fuzzing harness uses a fixed ABI (
res/big.abi), which contains a bunch of ABI definitions and parameters. In the future it might make sense to also generate the ABI at random (e.g., using the arbitrary crate).