New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve VersionMismatch error message #1422
base: master
Are you sure you want to change the base?
Conversation
The current error is a bit unclear, so added some clarification of which version is which.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 51 51
Lines 10348 10348
=======================================
Hits 8388 8388
Misses 1960 1960 ☔ View full report in Codecov by Sentry. |
You should not try to guess sqlite3_version. |
@gwenn i'm not "guessing" it for comparison reason, just formatting it for ease-of reading. Much better than simply print raw number i think |
For me, |
@gwenn friendly ping with above question. Thx! |
The current error is a bit unclear, so added some clarification of which version is which.