Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VersionMismatch error message #1422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Dec 17, 2023

The current error is a bit unclear, so added some clarification of which version is which.

The current error is a bit unclear, so added some clarification of which version is which.
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aeaacc4) 81.05% compared to head (3ef4fd7) 81.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1422   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files          51       51           
  Lines       10348    10348           
=======================================
  Hits         8388     8388           
  Misses       1960     1960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gwenn gwenn added the invalid label Dec 18, 2023
@gwenn
Copy link
Collaborator

gwenn commented Dec 18, 2023

You should not try to guess sqlite3_version.
Which is not (easily) comparable.
Hence the use of sqlite3_libversion_number.

@nyurik
Copy link
Contributor Author

nyurik commented Dec 18, 2023

@gwenn i'm not "guessing" it for comparison reason, just formatting it for ease-of reading. Much better than simply print raw number i think

@gwenn
Copy link
Collaborator

gwenn commented Dec 18, 2023

@gwenn i'm not "guessing" it for comparison reason, just formatting it for ease-of reading. Much better than simply print raw number i think

For me,
https://github.com/rusqlite/rusqlite/pull/1422/files#diff-068438172230084847676a638395a6ee9914094c2cb2d76f2c5de07f0d136ad4R285 tries to guess the sqlite3_version (or at least could be mistaken as the sqlite3_version)

@nyurik
Copy link
Contributor Author

nyurik commented Dec 18, 2023

@gwenn would you be ok with the first revision of this PR -- it simply prints the number with some context: 017d91d

@nyurik
Copy link
Contributor Author

nyurik commented Apr 11, 2024

@gwenn friendly ping with above question. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants