Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new subcategory Static Site Generator (SSG) #2361

Merged
merged 8 commits into from
May 28, 2024
Merged

Add new subcategory Static Site Generator (SSG) #2361

merged 8 commits into from
May 28, 2024

Conversation

JuanPabloDiaz
Copy link
Contributor

Fixes Issue

closes #2349

Changes proposed

Add new subcategory Static Site Generator (SSG)

This is my second PR. In which I moved back some elements that I took from other categories/subcategories.

I moved back VuePress, Nuxt.js, Hugo. (I still believe that those elements belong to SSG though)

Screenshots

Note to reviewers

@vercel Vercel
Copy link

vercel bot commented May 10, 2024

@JuanPabloDiaz is attempting to deploy a commit to the Rupali Haldiya's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added chore Might take time to finish goal: new-category Addition of new categories related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels May 10, 2024
github-actions[bot]
github-actions bot reviewed May 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, JuanPabloDiaz, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@github-actions github-actions bot mentioned this pull request May 10, 2024
Open
3 tasks
@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) May 28, 2024 6:53am

This was referenced May 16, 2024
Closed
Open
aftabrehan
aftabrehan previously approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

rupali-codes
rupali-codes previously approved these changes May 18, 2024
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Anmol-Baranwal
Anmol-Baranwal reviewed May 18, 2024
View reviewed changes
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanPabloDiaz
There is a similar client error.

image

I believe updating the branch will fix this.

@rupali-codes
Copy link
Owner

@JuanPabloDiaz There is a similar client error.

image

I believe updating the branch will fix this.

Yep, @JuanPabloDiaz could you please update your branch with LinksHub main?

@JuanPabloDiaz
Copy link
Contributor Author

@JuanPabloDiaz There is a similar client error.
image
I believe updating the branch will fix this.

Yep, @JuanPabloDiaz could you please update your branch with LinksHub main?

Done @rupali-codes

This was referenced May 19, 2024
Closed
Closed
@rupali-codes rupali-codes merged commit d282e11 into rupali-codes:main May 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Anmol-Baranwal Anmol-Baranwal Anmol-Baranwal left review comments

@rupali-codes rupali-codes rupali-codes left review comments

@aftabrehan aftabrehan aftabrehan left review comments

@CBID2 CBID2 Awaiting requested review from CBID2 CBID2 is a code owner

Assignees

@JuanPabloDiaz JuanPabloDiaz

Labels
chore Might take time to finish goal: new-category Addition of new categories related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADD] Static Site Generator
4 participants
@JuanPabloDiaz @rupali-codes @Anmol-Baranwal @aftabrehan