Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pulumi iac #2360

Merged
merged 2 commits into from
May 28, 2024
Merged

added pulumi iac #2360

merged 2 commits into from
May 28, 2024

Conversation

desteves
Copy link
Contributor

@desteves desteves commented May 10, 2024

Fixes Issue

Closes #2359

Changes proposed

Adds a json object to the iac.json list with a blurb about Pulumi and a link to the Pulumi docs.

Screenshots

Note to reviewers

N/A

Copy link

vercel bot commented May 10, 2024

@desteves is attempting to deploy a commit to the Rupali Haldiya's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, desteves, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 closed this May 10, 2024
@CBID2
Copy link
Collaborator

CBID2 commented May 10, 2024

Hi @desteves . Welcome to LinksHub! :) We don't accept pull requests for issues that we haven't reviewed and approved yet, so I'm so closing your pull request for now and will reopen it once I reviewed, approved, and assigned you to your issue. In the future, please wait until your issue has been approved and assigned to you before you submit a pull request. Refer to our Contributing Guide to learn how to effectively contribute to the project. Happy Contributing! 😊

@CBID2 CBID2 added goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos) labels May 10, 2024
@CBID2 CBID2 reopened this May 10, 2024
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @desteves. Can you remove the Signed-off-by: diana esteves [diana@atxyall.com](mailto:diana@atxyall.com) in your Pull Request? Putting this information poses as a security risk. If you need more tips on how to fill out your Pull Request's form, check out my blog post, "How To Make A Pull Request Without Pulling Your Hair Out"

@desteves
Copy link
Contributor Author

desteves commented May 10, 2024

Done @CBID2

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @Anmol-Baranwal @rupali-codes @aftabrehan, please review

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 9:25am

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Can you let him know why deployment failed?

@rupali-codes rupali-codes merged commit 45b874a into rupali-codes:main May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions priority: low Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] Pulumi IaC
4 participants