-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used .set() with { merge: true } to avoid overwriting the entire docu… #2354
Conversation
@Sarthak0203 is attempting to deploy a commit to the Rupali Haldiya's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Sarthak0203, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
DescriptionThis pull request modifies the Fixes Issue
Changes proposed
Note to reviewersPlease test the updated |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Anmol-Baranwal can you review this.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rupali-codes
I'm not entirely sure about the Firestore document structure, but this PR works for cases where we update resources without affecting any other fields that might already exist in the document.
If this is only for the importing the documents the first time, then we can do the overwriting.
Also @Anmol-Baranwal, Sarthak did not raise an issue for this, so in an effort to encourage open source etiquette, I highly think this PR should be closed, have them reread the contributing guide, and review their issue to see if it suits the project. |
@Anmol-Baranwal & @CBID2 we have temporarily put this feature on Hold. So, for now I'm closing this PR, we will look into it once we reactivate this feature. |
…ment
Fixes Issue
Changes proposed
Screenshots
Note to reviewers