Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used .set() with { merge: true } to avoid overwriting the entire docu… #2354

Closed
wants to merge 1 commit into from

Conversation

Sarthak0203
Copy link

…ment

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

Copy link

vercel bot commented May 2, 2024

@Sarthak0203 is attempting to deploy a commit to the Rupali Haldiya's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sarthak0203, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Sarthak0203
Copy link
Author

Description

This pull request modifies the GET function to avoid overwriting the entire document for each file in Firestore.

Fixes Issue

  • Overwriting of data in Firestore documents.

Changes proposed

  • Use .set() with { merge: true } to avoid overwriting the entire document in Firestore.

Note to reviewers

Please test the updated GET function thoroughly to ensure it works as expected and doesn't overwrite the entire document in Firestore

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ❌ Failed (Inspect) May 5, 2024 8:27am

@rupali-codes
Copy link
Owner

@Anmol-Baranwal can you review this..

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rupali-codes
I'm not entirely sure about the Firestore document structure, but this PR works for cases where we update resources without affecting any other fields that might already exist in the document.

If this is only for the importing the documents the first time, then we can do the overwriting.

@CBID2
Copy link
Collaborator

CBID2 commented May 28, 2024

@rupali-codes I'm not entirely sure about the Firestore document structure, but this PR works for cases where we update resources without affecting any other fields that might already exist in the document.

If this is only for the importing the documents the first time, then we can do the overwriting.

Also @Anmol-Baranwal, Sarthak did not raise an issue for this, so in an effort to encourage open source etiquette, I highly think this PR should be closed, have them reread the contributing guide, and review their issue to see if it suits the project.

@rupali-codes
Copy link
Owner

@Anmol-Baranwal & @CBID2 we have temporarily put this feature on Hold. So, for now I'm closing this PR, we will look into it once we reactivate this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants