RUN-2307 unit tests for edit project file

rundeckapp/grails-spa/packages/ui-trellis/src/app/components/readme-motd/EditProjectFile.spec.ts

@@ -35,9 +35,7 @@ jest.mock("@/library/rundeckService", () => ({
   }),
   url: jest.fn().mockReturnValue("http://localhost:4440"),
 }));
-
 let wrapper;
-
 const mountEditProjectFile = async (props = {}) => {
   wrapper = mount(EditProjectFile, {
     props: {
@@ -63,26 +61,21 @@ describe("EditProjectFile", () => {
     jest.clearAllMocks();
   });
 
-  // This test checks if the correct title is rendered based on the filename
-  describe.each([
+  it.each([
     ["readme.md", "edit.readme.label"],
     ["motd.md", "edit.motd.label"],
-  ])("renders the correct title for %s", (filename, expectedTitle) => {
-    it("checks title", async () => {
-      await mountEditProjectFile({ filename });
-      expect(wrapper.find('[data-test-id="title"]').text()).toContain(
-        expectedTitle,
-      );
-    });
+  ])("renders the correct title for %s", async (filename, expectedTitle) => {
+    await mountEditProjectFile({ filename });
+    expect(wrapper.find('[data-test-id="title"]').text()).toContain(
+      expectedTitle,
+    );
   });
 
-  // This test checks if the file content is rendered when the getFileText method returns successfully
   it("renders file content when getFileText method returns successfully", async () => {
     await wrapper.vm.$nextTick();
     expect(wrapper.vm.fileText).toBe("sample file content");
   });
 
-  // This test checks if an error is handled correctly when the getFileText method fails
   it("handles failure when getFileText method fails", async () => {
     (editProjectFileService.getFileText as jest.Mock).mockImplementationOnce(
       () => Promise.reject(new Error("Failed to fetch file")),
@@ -92,7 +85,6 @@ describe("EditProjectFile", () => {
     expect(wrapper.vm.notifyError).toHaveBeenCalledWith("Failed to fetch file");
   });
 
-  // This test checks if an error is handled correctly when the user edits the file and fails to save it
   it("handles failure when user edits the file and fails to save it", async () => {
     (editProjectFileService.saveProjectFile as jest.Mock).mockRejectedValue(
       new Error("Failed to save file"),
@@ -103,7 +95,6 @@ describe("EditProjectFile", () => {
     expect(wrapper.vm.notifyError).toHaveBeenCalledWith("Failed to save file");
   });
 
-  // This test checks if the file is saved successfully when the user edits the file and saves it
   it("handles success when user edits the file and saves it", async () => {
     wrapper.vm.fileText = "new content";
     await wrapper.find('[data-test-id="save"]').trigger("click");
@@ -112,7 +103,6 @@ describe("EditProjectFile", () => {
     ).toHaveBeenCalledWith("default", "readme.md", "new content");
   });
 
-  // This test checks if the correct message and configuration link are displayed when the user is an admin
   it("displays admin specific message and configuration link when user is an admin", async () => {
     await mountEditProjectFile({
       displayConfig: ["none"],
@@ -124,7 +114,6 @@ describe("EditProjectFile", () => {
     );
   });
 
-  // This test checks if the correct message is displayed when the user is not an admin
   it("displays non-admin specific message when user is not an admin", async () => {
     await mountEditProjectFile({
       authAdmin: false,
@@ -135,31 +124,17 @@ describe("EditProjectFile", () => {
       "file.warning.not.displayed.nonadmin.message",
     );
   });
-
-  // This test checks if the save button is not displayed for non-admin users
   it("does not allow non-admin user to save the file", async () => {
     await mountEditProjectFile({ authAdmin: false });
     expect(wrapper.find('[data-test-id="save"]').exists()).toBe(false);
   });
-
-  // This test checks if the editor is not displayed for non-admin users
   it("does not allow non-admin user to edit the file", async () => {
     await mountEditProjectFile({ authAdmin: false });
     expect(wrapper.find('[data-test-id="editor"]').exists()).toBe(false);
   });
 
-  // This test checks if the Ace Editor is rendered
-  it("renders the Ace Editor", () => {
-    const aceEditor = wrapper.find('[data-test-id="ace-editor"]');
-    expect(aceEditor.exists()).toBe(true);
-  });
+  //TODO: working on this one
+  // it("does not change file content when user cancels the edit", async () => {
+  //
+  // });
 });
-
-// This one is commented out because it is not working as expected
-// it("does not change file content when user cancels the edit", async () => {
-//   const originalFileText = wrapper.vm.fileText;
-//   wrapper.vm.fileText = "new content";
-//   await wrapper.find('[data-test-id="cancel"]').trigger("click");
-//   console.log("After click event:", wrapper.vm.fileText);
-//   expect(wrapper.vm.fileText).toBe(originalFileText);
-// });

rundeckapp/grails-spa/packages/ui-trellis/src/app/components/readme-motd/EditProjectFile.vue

@@ -59,17 +59,17 @@
                 <button
                   type="button"
                   class="btn btn-default reset_page_confirm"
-                  @click="createProjectHomeLink"
                   data-test-id="cancel"
+                  @click="createProjectHomeLink"
                 >
                   Cancel
                 </button>
                 <button
                   v-if="authAdmin"
                   type="submit"
                   class="btn btn-cta reset_page_confirm"
-                  @click="saveProjectFile"
                   data-test-id="save"
+                  @click="saveProjectFile"
                 >
                   Save
                 </button>
@@ -132,6 +132,7 @@ export default defineComponent({
   data() {
     return {
       fileText: "",
+
       markdownSectionOpen: false,
       errorMsg: "",
     };