RSE-864 Fix: Case sensitive in users when used LDAP OSS #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus-Osuna-M
changed the title
Jesus-Osuna-M
changed the title
Jesus-Osuna-M
added
the
needs documentation
Jesus-Osuna-M
force-pushed
the
RSE-864-case-sensive-in-users-when-used-ldap
branch
from
68a170c
to
5054043
Compare
Jesus-Osuna-M
force-pushed
the
RSE-864-case-sensive-in-users-when-used-ldap
branch
from
5054043
to
61e8604
Compare
gschueler
requested changes
Apr 25, 2024
rundeckapp/src/main/groovy/org/rundeck/app/data/providers/GormUserDataProvider.groovy
Show resolved
Hide resolved
…UserDataProvider.groovy Co-authored-by: Greg Schueler <greg.schueler@gmail.com>
gschueler
requested changes
Apr 29, 2024
rundeckapp/src/main/groovy/org/rundeck/app/data/providers/GormUserDataProvider.groovy
Outdated
Show resolved
Hide resolved
core/src/main/java/com/dtolabs/rundeck/core/config/RundeckConfigBase.java
Show resolved
Hide resolved
gschueler
reviewed
Apr 30, 2024
rundeckapp/src/main/groovy/org/rundeck/app/data/providers/GormUserDataProvider.groovy
Outdated
Show resolved
Hide resolved
gschueler
reviewed
Apr 30, 2024
rundeckapp/src/test/groovy/org/rundeck/app/providers/GormUserDataProviderSpec.groovy
Outdated
Show resolved
Hide resolved
gschueler
approved these changes
Apr 30, 2024
…ataProviderSpec.groovy Co-authored-by: Greg Schueler <greg.schueler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
https://pagerduty.atlassian.net/browse/RSE-864
https://pagerduty.atlassian.net/browse/RSE-961
Problem:
The username on rundeck is case sensitive while usernames un LDAP are case insensitive this difference generated duplicated users on the RDUSER table since.
Solution:
The use of the method getUserByLoginOrCreate was replaced by findOrCreateUser since both methods had the same logic.
A new feature flag was added to the config.properties
By default, this flag will be false meaning that username on login will be case sensitive.
Fixes #6733