Run-2255 add unit tests for RundeckInfo component #9048

jayas006 · 2024-04-08T19:47:27Z

Is this a bugfix, or an enhancement? Please describe.

This is an enhancement. I have created RundeckInfo.spec.ts to check if theRundeckInfocomponents of our project works right. This helps us make sure everything in RundeckInfo is working well.

Describe the solution you've implemented

In the RundeckInfo.spec.ts file, I wrote tests to check different parts of RundeckInfo. These tests help us find problems early and make sure we don't mess up the RundeckInfo when we change other things in the future.

Describe alternatives you've considered

Additional context

smartinellibenedetti

It's a good start, left comments and pointers. Also, all the properties "versionProps", "serverProps", "VersionDisplay", "latestProps" can be moved to the mount method to make the tests cleaner.

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

smartinellibenedetti · 2024-04-08T20:33:10Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    };
+    const wrapper = await mountRundeckInfo({ version: versionProps });
+    const versionComponent = wrapper.findComponent({ name: "RundeckVersion" });
+    expect(versionComponent.exists()).toBe(true);


2 things:

the text you write in the "it" is meant to describe what the test does. In this case "renders information correctly". To check this, it's not enough to only assert if that component exists, especially since this component will actually generate the text it will display by combining the properties from the versionProps.

secondly, you should check for the final dom elements, in this case, find the span inside versionComponent and check that the text generated is what it should be.

Thanks for the feedback. I am going to look at it

smartinellibenedetti · 2024-04-08T20:35:51Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(serverComponent.props()).toEqual({
+      name: serverProps.name,
+      glyphicon: serverProps.icon,
+      uuid: serverProps.uuid,
+      showId: serverProps.showId,
+    });


Suggested change

expect(serverComponent.props()).toEqual({

name: serverProps.name,

glyphicon: serverProps.icon,

uuid: serverProps.uuid,

showId: serverProps.showId,

});

expect(serverComponent.props()).toEqual(serverProps);

I have first applied it expect(serverComponent.props()).toEqual(serverProps); but it was giving error - ```
"icon": "paperclip",

"glyphicon": "paperclip",
"name": "localHost",

"nameClass": undefined,
"showId": true,
"uuid": "uuid1",
}

Then I looked at the SeverDisplay prop then these are included

glyphicon: String,
uuid: String,
name: String,
nameClass: String,
showId: { default: true },
``` and also showing in the devTool. Though nameClass is undefined so I didn't include it in the test.

To test Prop I saw this link. https://vueschool.io/articles/vuejs-tutorials/how-to-test-custom-prop-validators-in-vuejs/
So instead of testing each props it can might work like this.
expect(serverComponent.props()).toMatchObject({
name: serverProps.name,
glyphicon: serverProps.icon,
uuid: serverProps.uuid,
showId: serverProps.showId,
});
I am testing locally to trying to see the differences. This also worked but I wasn't sure to include it. In our focus time I will note down these to discuss.

The link you've added in your comment is not related to unit tests, it's about adding validation in the component to ensure that what is passed as a prop has the correct type or value.

While it's perfectly valid to test that the props being passed are correct, we should prioritize asserting dom elements and data that has been massaged. So in this scenario, it's more beneficial to test the title of the span has the correct value, as it is generated from a combination of 3 other props.

smartinellibenedetti · 2024-04-08T20:36:57Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(latestVersionComponent.props()).toEqual({
+      logo: latestProps.logo,
+      number: latestProps.full,
+      tag: latestProps.tag,
+      logocss: latestProps.logocss,
+    });


Suggested change

expect(latestVersionComponent.props()).toEqual({

logo: latestProps.logo,

number: latestProps.full,

tag: latestProps.tag,

logocss: latestProps.logocss,

});

expect(latestVersionComponent.props()).toEqual(latestProps);

Would like you to add another expect here, checking that the span of rundeckVersion has the expected text

smartinellibenedetti · 2024-04-08T20:42:43Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const wrapper = await mountRundeckInfo({
+      latest: latestProps,
+    });
+    const latestVersionComponent = wrapper.findComponent({


it's a good practice to name the const with the name of the component

Suggested change

const latestVersionComponent = wrapper.findComponent({

const rundeckVersionComponent = wrapper.findComponent({

smartinellibenedetti

There's still work to do, but you're on the right track. I've left some new pointers, let me know if you have any doubts.

smartinellibenedetti · 2024-04-10T15:33:20Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const latestSection = wrapper
+      .find(".rundeck-info-widget__latest")
+      .findComponent({ name: "RundeckVersion" });


You don't need to the .find here, the .findComponent method will find the component as long it's rendered. Changes to do:

remove .find(".rundeck-info-widget__latest")

rename latestSection to rundeckVersionComponent and update the rest of this test to use the new name

You don't need to the .find here, the .findComponent method will find the component as long it's rendered. Changes to do:

remove .find(".rundeck-info-widget__latest")

rename latestSection to rundeckVersionComponent and update the rest of this test to use the new name

Done:
removed .find(".rundeck-info-widget__latest")
renamed latestSection to rundeckVersionComponent and update the rest of this test to use the new name

smartinellibenedetti · 2024-04-10T15:36:35Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+  it("should have an anchor with the correct href", async () => {
+    const wrapper = await mountRundeckInfo();
+    const expectedHref = "http://localhost";
+    const anchorElement = wrapper.find(`a[href="${expectedHref}"]`);


So ideally here you don't want to select the a by the property you're about to test, but by a data-test-id (it's more resilient. Changes to do:

add a data-test-id for the <a> you're going to test in RundeckInfo.vue;

update test to find this a by the data-test-id;

So ideally here you don't want to select the a by the property you're about to test, but by a data-test-id (it's more resilient. Changes to do:

add a data-test-id for the <a> you're going to test in RundeckInfo.vue;

update test to find this a by the data-test-id;

Fixed

smartinellibenedetti · 2024-04-10T15:39:06Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    props: {
+      appInfo: { title: "Rundeck", logocss: "some-css" },
+      ...props,
+    },


By my previous comment in this PR, I'd like to move the props here. Ie:

Suggested change

props: {

appInfo: { title: "Rundeck", logocss: "some-css" },

...props,

},

props: {

appInfo: { title: "Rundeck", logocss: "some-css" },

version: { logo: false,

logocss: "some-css",

number: "1.0.0",

tag: "stable",

title: "Rundeck", },

/// add the other props here

...props,

},

The goal is to keep tests dry, but also mount the components with everything you need for the tests, while having the ability to override something if needed.

smartinellibenedetti · 2024-04-10T15:41:12Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(latestSection.props("number")).toEqual(latestProps.full);
+    expect(latestSection.props("tag")).toEqual(latestProps.tag);


Also, would like you to add another expect here, checking that the span of rundeckVersion has the expected text

Also, would like you to add another expect here, checking that the span of rundeckVersion has the expected text
I have question regarding latest release:
In the latest release even though tag is included but the output it is giving "Rundeck and number". Then I checked the computed property and it seems like tag is not included

computed: { cssclass(): string { return `${this.logocss} app-logo`; }, text(): string { const { title, number, tag } = this; let text = ""; text += `${title ? title + " " : ""}`; text += `${number}`; return text; }, },

Two ways I am thinking to fix it. Either I include tag in the computed property or don't use tag in the test as the actual output it is asking { title: "Rundeck", full: "1.0.0" }

I am sending fix. Please review and suggest. Thanks

Also, would like you to add another expect here, checking that the span of rundeckVersion has the expected text
I have question regarding latest release:
In the latest release even though tag is included but the output it is giving "Rundeck and number". Then I checked the computed property and it seems like tag is not included

computed: { cssclass(): string { return `${this.logocss} app-logo`; }, text(): string { const { title, number, tag } = this; let text = ""; text += `${title ? title + " " : ""}`; text += `${number}`; return text; }, },

Two ways I am thinking to fix it. Either I include tag in the computed property or don't use tag in the test as the actual output it is asking { title: "Rundeck", full: "1.0.0" }

I am sending fix. Please review and suggest. Thanks

realized that span of rundeckVersion has the expected text of title and number and no need to test tag there. Added tag in my new commit which I removed in this commit.

jayas006 · 2024-04-12T19:47:24Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

@@ -120,6 +124,7 @@ describe("RundeckInfo", () => {
    expect(rundeckVersionComponent.exists()).toBe(true);
    expect(rundeckVersionComponent.props("title")).toEqual(latestProps.title);
    expect(rundeckVersionComponent.props("number")).toEqual(latestProps.full);
+    expect(rundeckVersionComponent.props("tag")).toEqual(latestProps.tag);


included tag now here and also added one more expect for checking that the span of rundeckVersion has the expected text which is in previous commit. Please suggest If I am missing something.

To do:

remove lines 125 up to 127 (due to reasons explained in previous comment);

change line 129 to the literal string instead of ${latestProps.title} ${latestProps.full} as previously discussed;

jayas006 · 2024-04-12T19:55:27Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(latestSection.props("number")).toEqual(latestProps.full);
+    expect(latestSection.props("tag")).toEqual(latestProps.tag);


Also, would like you to add another expect here, checking that the span of rundeckVersion has the expected text
I have question regarding latest release:
In the latest release even though tag is included but the output it is giving "Rundeck and number". Then I checked the computed property and it seems like tag is not included

computed: { cssclass(): string { return `${this.logocss} app-logo`; }, text(): string { const { title, number, tag } = this; let text = ""; text += `${title ? title + " " : ""}`; text += `${number}`; return text; }, },

Two ways I am thinking to fix it. Either I include tag in the computed property or don't use tag in the test as the actual output it is asking { title: "Rundeck", full: "1.0.0" }

I am sending fix. Please review and suggest. Thanks

realized that span of rundeckVersion has the expected text of title and number and no need to test tag there. Added tag in my new commit which I removed in this commit.

smartinellibenedetti

Some comments were not addressed so I will recap them here. As we spoke before, the reason to create a method on the top of the test suite to return the mounted component is to avoid repetition/having to pass the same props every time you write a test.

So unless there is a scenario where the component needs to be mounted with a different set of values (like on line 44), there's no need to declare versionProps, latestProps, etc.

Also, props required by a component, may not be a prop for their child and vice-versa. Therefore, it's important to check how these values are being defined to avoid the scenario of generating console warnings that mismatches are happening (by either passing extra props or lacking the required ones).

ShowId isn't a prop for RundeckInfo, but for ServerDisplay component, that when it's not passed, it has the default value of true. As there isn't anything in RundeckInfo that points out that it also requires this prop, we shouldn't pass this property when mounting this component.

Lastly, when asserting the value of an object, it's fine to pass a variable, but when asserting the value of a string, please write the literal value to highlight the intention.

smartinellibenedetti · 2024-04-15T16:15:35Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const versionProps = {
+      logo: false,
+      logocss: "some-css",
+      number: "1.0.0",
+      tag: "stable",
+      title: "Rundeck",
+    };


To do: remove versionProps const as it's unused

smartinellibenedetti · 2024-04-15T16:18:55Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const versionProps = {
+      logo: false,
+      logocss: "some-css",
+      number: "5.3.0",
+      title: "Rundeck",
+    };
+
+    const wrapper = await mountRundeckInfo({ version: versionProps });


To do:

remove versionProps const;

update line 66 to: const wrapper = await mountRundeckInfo();

either update line 75 to match the values you've passed in mountRundeckInfo OR update the values in mountRundeckInfo so that test will pass;

smartinellibenedetti · 2024-04-15T16:49:28Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const expectedUrl = "http://localhost";
+    const anchorElement = wrapper.find('[data-test-id="welcome-link"]');
+    expect(anchorElement.exists()).toBe(true);
+    expect(anchorElement.attributes("href")).toBe(expectedUrl);


To do:

remove expectedUrl const;

update line 137 to : expect(anchorElement.attributes("href")).toBe("http://localhost");

smartinellibenedetti · 2024-04-15T17:36:18Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+      version: {
+        logo: false,
+        logocss: "some-css",
+        number: "1.0.0",
+        tag: "stable",
+        title: "Rundeck",
+      },
+      server: {
+        name: "localHost",
+        icon: "paperclip",
+        uuid: "uuid1",
+        showId: true,
+      },


When mounting a component, you must ensure that the component will be mounted with all the required props and that they match their type definition. In the case of rundeckInfo, the type definitions live in the file store/System.ts.

To do:

remove from version object: logo, logocss, title;

add to version object:

name: "Erebus", color: "red", icon: "glass", edition: "Community",

also, add the object for latest (that you have in one of your latest tests), with the following properties:

full: "v5.2.0-20240410", number: "5.2.0", tag: "GA", color: "aquamarine", date: new Date(), icon: "knight", edition: "Community"

smartinellibenedetti · 2024-04-15T17:43:35Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const serverProps = {
+      name: "localHost",
+      icon: "paperclip",
+      uuid: "uuid1",
+      showId: true,
+    };
+    const wrapper = await mountRundeckInfo({ server: serverProps });


You don't need to pass the serverProps again, because you've defined the default values in the mount method. To do:

remove serverProps const;

update line 84 to: const wrapper = await mountRundeckInfo();

update line 2 in ServerDisplay.vue, adding a data-test-id attribute: data-test-id="server-title"

update line 88 to check that the span with the data-test-id you've just added, has a title attribute with the value of paperclip-uu / uuid1

Important, do not do write the expected value as a variable. We spoke about this in the last meeting, on tests we want to write the literal strings when asserting text.

smartinellibenedetti · 2024-04-15T17:51:14Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(serverComponent.props()).toEqual({
+      name: serverProps.name,
+      glyphicon: serverProps.icon,
+      uuid: serverProps.uuid,
+      showId: serverProps.showId,
+    });


The link you've added in your comment is not related to unit tests, it's about adding validation in the component to ensure that what is passed as a prop has the correct type or value.

While it's perfectly valid to test that the props being passed are correct, we should prioritize asserting dom elements and data that has been massaged. So in this scenario, it's more beneficial to test the title of the span has the correct value, as it is generated from a combination of 3 other props.

smartinellibenedetti · 2024-04-15T17:51:45Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const versionDisplay = {
+      name: "Rundeck",
+      icon: "icon-url",
+      color: "lamp",
+    };
+    const wrapper = await mountRundeckInfo({ version: versionDisplay });


To do:

remove versionProps const;

update line 102 to: const wrapper = await mountRundeckInfo();

smartinellibenedetti · 2024-04-15T17:52:20Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    const latestProps = {
+      title: "Rundeck",
+      full: "1.0.0",
+      tag: "stable",
+    };
+
+    const wrapper = await mountRundeckInfo({
+      latest: latestProps,
+    });


To do:

remove latestProps const;

update line 117 to: const wrapper = await mountRundeckInfo();

smartinellibenedetti · 2024-04-15T17:53:50Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

@@ -120,6 +124,7 @@ describe("RundeckInfo", () => {
    expect(rundeckVersionComponent.exists()).toBe(true);
    expect(rundeckVersionComponent.props("title")).toEqual(latestProps.title);
    expect(rundeckVersionComponent.props("number")).toEqual(latestProps.full);
+    expect(rundeckVersionComponent.props("tag")).toEqual(latestProps.tag);


To do:

remove lines 125 up to 127 (due to reasons explained in previous comment);

change line 129 to the literal string instead of ${latestProps.title} ${latestProps.full} as previously discussed;

jayas006 · 2024-04-16T15:00:06Z

Thank you @smartinellibenedetti , sending fix in few minutes

smartinellibenedetti

Good progress! Left a few suggestions for the tests' descriptions that could be a little bit more clear. There are 2 small fixes to be done but afterwards, it's good to merge!

smartinellibenedetti · 2024-05-06T14:49:58Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    );
+    expect(wrapper.findComponent({ name: "RundeckLogo" }).exists()).toBe(false);
+  });
+  it("renders RundeckVersions information with correct props", async () => {


Suggested change

it("renders RundeckVersions information with correct props", async () => {

it("renders RundeckVersion information with correct props", async () => {

smartinellibenedetti · 2024-05-06T14:52:11Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    );
+    expect(wrapper.findComponent({ name: "RundeckLogo" }).exists()).toBe(false);
+  });
+  it("renders RundeckVersions information with correct props", async () => {


Suggested change

it("renders RundeckVersions information with correct props", async () => {

it("renders the correct Rundeck version based on number and title props", async () => {

smartinellibenedetti · 2024-05-06T15:24:19Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+
+    expect(rundeckVersionComponent.find("span").text()).toBe("Rundeck 1.0.0");
+  });
+  it("renders ServerDisplay correctly with default props", async () => {


Suggested change

it("renders ServerDisplay correctly with default props", async () => {

it("renders the server's shortened uuid along with a title attribute", async () => {

smartinellibenedetti · 2024-05-06T15:25:28Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(
+      serverComponent.find('[data-test-id="server-title"]').attributes("title"),
+    ).toBe("paperclip-uu / uuid1");


Please add here another expect that checks that there's a span with the text equal to the short uuid

smartinellibenedetti · 2024-05-06T15:29:50Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    ).toBe("paperclip-uu / uuid1");
+  });
+
+  it("renders version display correctly", async () => {


Suggested change

it("renders version display correctly", async () => {

it("renders Rundeck's version display name", async () => {

smartinellibenedetti · 2024-05-06T15:40:34Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(rundeckVersionComponent.exists()).toBe(true);
+    expect(rundeckVersionComponent.find("span").text()).toBe("Rundeck 1.0.0");


RundeckInfo renders 2 RundeckVersion components - one that you've tested before, that will render "Rundeck 1.0.0", and one that renders the latest release info.

This test should be checking the text of the second RundeckVersion. To do so, you can use the method findAllComponents as findComponent will always return the first occurrence that matches what you're searching.

smartinellibenedetti · 2024-05-06T17:29:08Z

rundeckapp/grails-spa/package-lock.json

@@ -0,0 +1,1108 @@
+{


@jayas006 could you please delete this package-lock?

jayas006 · 2024-05-06T19:11:36Z

@smartinellibenedetti thanks for the pointers. I've fixed it.

smartinellibenedetti

Please delete the package-lock.json

smartinellibenedetti · 2024-05-06T19:24:57Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+  it("renders the link with the correct href", async () => {
+    const wrapper = await mountRundeckInfo();
+    const anchorElement = wrapper.find('[data-test-id="welcome-link"]');
+    expect(anchorElement.exists()).toBe(true);


Don't need to change this but a note for the future: if an element doesn't have a v-if, you don't need to assert every time that the element exists

smartinellibenedetti · 2024-05-06T19:28:31Z

...ails-spa/packages/ui-trellis/src/library/components/widgets/rundeck-info/RundeckInfo.spec.ts

+    expect(
+      serverComponent.find('[data-test-id="server-title"]').attributes("title")
+    ).toBe("paperclip-uu / uuid1");
+    expect(serverComponent.find("span").text()).toBe("uulocalHost");


Heads-up, this assertion is wrong as it's getting the first parent span and concatenating all the content from the subsequent spans. Please use a data-test-id on the span that renders the {{shortUuid}}, so that you'll expect the text to be just 2 characters (in your case, uu)

smartinellibenedetti

good to go!

smartinellibenedetti reviewed Apr 8, 2024

View reviewed changes

smartinellibenedetti reviewed Apr 10, 2024

View reviewed changes

jayas006 requested a review from smartinellibenedetti April 12, 2024 17:48

jayas006 commented Apr 12, 2024

View reviewed changes

smartinellibenedetti requested changes Apr 15, 2024

View reviewed changes

smartinellibenedetti mentioned this pull request Apr 18, 2024

RUN-2309: Update tsconfig.build.json to properly recognize jest #9070

Merged

smartinellibenedetti requested changes May 6, 2024

View reviewed changes

smartinellibenedetti reviewed May 6, 2024

View reviewed changes

jayas006 requested a review from smartinellibenedetti May 6, 2024 19:11

jayas006 added 9 commits May 6, 2024 13:28

add unit tests for RundeckInfo component

0950a7c

fixed the script

60df352

updated script to fix issue

ed19edc

removed tag as not used in text computed property

fac080e

removed tag from latest release test

8595844

cleaned script in latest release

a6213ab

include tag in latest release test

d279b17

fixed the script

524222c

updating test descriptions to improve clarity

78086b9

smartinellibenedetti force-pushed the feat/unit-test-for-rundeckInfo branch from abc63db to 78086b9 Compare May 6, 2024 19:28

smartinellibenedetti requested changes May 6, 2024

View reviewed changes

jayas006 added 4 commits May 7, 2024 12:11

corrected unit tests for RundeckInfo and update server display

be94542

Remove package-lock.json

d6efc12

Update tests for ServerDisplay component in RundeckInfo.spec.ts

e4cc029

removed commented line

c34e4e2

smartinellibenedetti approved these changes May 7, 2024

View reviewed changes

smartinellibenedetti added this to the 5.3.0 milestone May 7, 2024

jayas006 added 2 commits May 7, 2024 22:26

Merge branch 'main' into feat/unit-test-for-rundeckInfo

7836f65

Merge branch 'main' into feat/unit-test-for-rundeckInfo

46a69e0

ltamaster merged commit 05e5133 into main May 8, 2024
3 checks passed

ltamaster deleted the feat/unit-test-for-rundeckInfo branch May 8, 2024 18:39

	const latestVersionComponent = wrapper.findComponent({
	const rundeckVersionComponent = wrapper.findComponent({

		expect(latestSection.props("number")).toEqual(latestProps.full);
		expect(latestSection.props("tag")).toEqual(latestProps.tag);

	it("renders RundeckVersions information with correct props", async () => {
	it("renders RundeckVersion information with correct props", async () => {

	it("renders RundeckVersions information with correct props", async () => {
	it("renders the correct Rundeck version based on number and title props", async () => {

	it("renders ServerDisplay correctly with default props", async () => {
	it("renders the server's shortened uuid along with a title attribute", async () => {

	it("renders version display correctly", async () => {
	it("renders Rundeck's version display name", async () => {

		expect(rundeckVersionComponent.exists()).toBe(true);
		expect(rundeckVersionComponent.find("span").text()).toBe("Rundeck 1.0.0");

Run-2255 add unit tests for RundeckInfo component #9048

Run-2255 add unit tests for RundeckInfo component #9048

Conversation

jayas006 commented Apr 8, 2024 • edited

smartinellibenedetti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smartinellibenedetti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayas006 Apr 12, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayas006 Apr 12, 2024 • edited

Choose a reason for hiding this comment

smartinellibenedetti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayas006 commented Apr 16, 2024

smartinellibenedetti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smartinellibenedetti May 6, 2024 • edited

Choose a reason for hiding this comment

jayas006 commented May 6, 2024

smartinellibenedetti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smartinellibenedetti May 6, 2024 • edited

Choose a reason for hiding this comment

smartinellibenedetti left a comment

Choose a reason for hiding this comment

jayas006 commented Apr 8, 2024 •

edited

jayas006 Apr 12, 2024 •

edited

jayas006 Apr 12, 2024 •

edited

smartinellibenedetti May 6, 2024 •

edited

smartinellibenedetti May 6, 2024 •

edited