Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency follow-redirects to v1.15.6 [SECURITY] - autoclosed #9010

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Mar 17, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
follow-redirects 1.15.4 -> 1.15.6 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-28849

When using axios, its dependency follow-redirects only clears authorization header during cross-domain redirect, but allows the proxy-authentication header which contains credentials too.

Steps To Reproduce & PoC

Test code:

const axios = require('axios');

axios.get('http://127.0.0.1:10081/', {
 headers: {
 'AuThorization': 'Rear Test',
 'ProXy-AuthoriZation': 'Rear Test',
 'coOkie': 't=1'
 }
})
 .then((response) => {
 console.log(response);
 })

When I meet the cross-domain redirect, the sensitive headers like authorization and cookie are cleared, but proxy-authentication header is kept.

Impact

This vulnerability may lead to credentials leak.

Recommendations

Remove proxy-authentication header during cross-domain redirect

Recommended Patch

follow-redirects/index.js:464

- removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
+ removeMatchingHeaders(/^(?:authorization|proxy-authorization|cookie)$/i, this._options.headers);

Release Notes

follow-redirects/follow-redirects (follow-redirects)

v1.15.6

Compare Source

v1.15.5

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title Update dependency follow-redirects to v1.15.6 [SECURITY] chore(deps): update dependency follow-redirects to v1.15.6 [security] Mar 18, 2024
@renovate renovate bot changed the title chore(deps): update dependency follow-redirects to v1.15.6 [security] Update dependency follow-redirects to v1.15.6 [SECURITY] Mar 26, 2024
@renovate renovate bot changed the title Update dependency follow-redirects to v1.15.6 [SECURITY] chore(deps): update dependency follow-redirects to v1.15.6 [security] Apr 3, 2024
@renovate renovate bot changed the title chore(deps): update dependency follow-redirects to v1.15.6 [security] Update dependency follow-redirects to v1.15.6 [SECURITY] Apr 11, 2024
@renovate renovate bot changed the title Update dependency follow-redirects to v1.15.6 [SECURITY] Update dependency follow-redirects to v1.15.6 [SECURITY] - autoclosed Apr 25, 2024
@renovate renovate bot closed this Apr 25, 2024
@renovate renovate bot deleted the renovate/npm-follow-redirects-vulnerability branch April 25, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants