Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weak/node-gyp dependency #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

swim
Copy link

@swim swim commented Mar 23, 2017

When running Phantom on a Windows box it defaults to requiring node-gyp. However, this is not required; please see https://github.com/amir20/phantomjs-node/tree/v1#use-it-in-windows. This should also address an old issue #2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.441% when pulling 093a911 on swim:remove-weak-dep into 4ae680b on ruipgil:master.

@ruipgil
Copy link
Owner

ruipgil commented Apr 2, 2017

You can pass an object with those functions, when you're instantiating a dynamic scraper. I feel that this is unnecessary to be baked in. Maybe a note in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants