Replaced SSF by numfmt (ECMA-376 support) #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juanparati Thanks. This is a big change. I need to look into this deeply to ensure it doesn't break anything. |
zyc9012
force-pushed
the
master
branch
3 times, most recently
from
471416d
to
829cacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced SSF by numfmt the reasons what I did that is because SSF doesn't support custom localization features. To replace SSF by numfmt it will open the door to use custom localization features like number formats, currencies, etc.
Numfmt supports by default Chinese (traditional and simplified), Spanish and English among other locales.