-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor and adding unit test case #4679
fix: refactor and adding unit test case #4679
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## allow_no_body_for_query_parameter_source #4679 +/- ##
============================================================================
- Coverage 74.56% 74.52% -0.05%
============================================================================
Files 413 413
Lines 48706 48706
============================================================================
- Hits 36318 36298 -20
- Misses 10008 10032 +24
+ Partials 2380 2376 -4 ☔ View full report in Codecov by Sentry. |
body, err := io.ReadAll(req.request.Body) | ||
_ = req.request.Body.Close() | ||
|
||
body, err := prepareRequestBody(req.request, slices.Contains(bt.webhook.config.sourceListForParsingParams, strings.ToLower(breq.sourceType)), breq.sourceType, bt.webhook.config.sourceListForParsingParams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SourceType is getting lower case in function prepareRequestBody
f766469
into
allow_no_body_for_query_parameter_source
) * fix: source payloads with query params to be allowed without body * fix: adding adjust in sourceListForParsingParams * fix: small edit * fix: review comment addressed * fix: query params not added with iteration (#4678) * fix: review comment addressed * fix: edit with sjson * fix: refactor and adding unit test case (#4679) * fix: refactor and addition of test cases * fix: small change * Apply suggestions from code review Co-authored-by: Akash Chetty <achetty.iitr@gmail.com> * fix: review comments addressed * fix: small fix * Apply suggestions from code review Co-authored-by: Akash Chetty <achetty.iitr@gmail.com> * fix: review comments addressed * fix: review comments addressed * fix: logs added * Revert "fix: logs added" This reverts commit e3b4afe. --------- Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Description
refactoring the code and adding unit test case for the util function
Linear Ticket
< Replace with Linear Link >
Security