chore: avoid sending warehouseID in stats

[achettyiitr]

Description

• Avoid sending warehouseID in stats since we already have sourceID and destinationID we don't need warehouseID which is essentially a combination of (sourceName, destinationName, sourceID, destiantionID).
• For new tags following the standards we have in observability-kit.
• Current Plan Overview:
  • Ensuring Availability of Stable Identifiers: In all statistics where warehouseID is utilized, sourceID and destID are ensured to be available. For any instances where these identifiers are absent, they are added.
  • Transitioning from warehouseID: Once the new tags (sourceID and destID) are consistently populated, the next step involves removing warehouseID from the metrics dashboard and alerts. Instead, sourceID and destID will be used for contextual information if necessary. (PIPE-1089)
  • Application Code Update: Following the successful correction of metrics dashboards and alerts, the final step entails removing references to warehouseID from the application code. (PIPE-1090)

This improved version provides clearer explanations and organizes the plan's steps for better readability and understanding.

Linear Ticket

• Resolves PIPE-1088

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[coderabbitai]

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Tip

Early Access Features

• gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to full the review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.60%. Comparing base (99d085d) to head (9f42e4e).
Report is 1 commits behind head on master.

Files	Patch %	Lines
warehouse/bcm/backend_config.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4667      +/-   ##
==========================================
+ Coverage   74.52%   74.60%   +0.08%     
==========================================
  Files         416      414       -2     
  Lines       49269    48546     -723     
==========================================
- Hits        36718    36220     -498     
+ Misses      10112     9952     -160     
+ Partials     2439     2374      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sidddddarth]

Looks like destID is in use in other places.

Suggested change

	"destinationID": destID,
	"destID": destID,

[achettyiitr]

Yean, I noticed that as well. There are dis-similarities around destID vs destinationID.

[achettyiitr]

I was discussing the same with @lvrach around the mismatch of tags. We thought of following these steps:

1. Add additional tags where there are mismatches, like in say in this particular case we will add let's say destID.
2. Check operator, if we have alerts or dashboards requires those tags, we can replace them, like in say in this particular case we will replace destinationID with destID.
3. Once we have no dependency we will remove it from the code, like in say removing destinationID from stat.

[Sidddddarth]

LGTM apart from one use of destinationID instead of destID for a stat tag.

[lvrach]

As @Sidddddarth mentions, why not use destinationId? https://github.com/rudderlabs/rudder-observability-kit/blob/main/go/labels/common.go#L11